Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance): update Souin setup & enable Cache-Control public in docs #1969

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

laurent-bientz
Copy link
Contributor

Hello,

This pull request updates Souin setup in docs, see dunglas/frankenphp#976 (comment)

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for improving this, this is much appreciated! I left a comment regarding public, then we'll be ready to merge.

core/performance.md Outdated Show resolved Hide resolved
@dunglas
Copy link
Member

dunglas commented Aug 20, 2024

By the way, the config can now be simplified:

Before:

{
    order cache before rewrite
    ...
    cache {
        api {
            souin
        }
    }
}

After:

{
    cache
    # ...
}

# ...

@laurent-bientz
Copy link
Contributor Author

@dunglas I followed your recommendations, tell me if everything is ok

@dunglas dunglas merged commit 1278e59 into api-platform:3.3 Aug 20, 2024
1 check failed
@dunglas
Copy link
Member

dunglas commented Aug 20, 2024

Thank you!!

soyuka pushed a commit that referenced this pull request Sep 18, 2024
* feat(performance): update Souin setup & enable Cache-Control public in docs

* feat(performance): simplify caddy config

* feat(performance): remove http_cache public directive

* feat(performance): add an example to set Cache-Control per api resource

* feat(performance): remove http_cache public directive for varnish

* Update performance.md

---------

Co-authored-by: Laurent Bientz <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
soyuka pushed a commit that referenced this pull request Sep 18, 2024
* feat(performance): update Souin setup & enable Cache-Control public in docs

* feat(performance): simplify caddy config

* feat(performance): remove http_cache public directive

* feat(performance): add an example to set Cache-Control per api resource

* feat(performance): remove http_cache public directive for varnish

* Update performance.md

---------

Co-authored-by: Laurent Bientz <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants