-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(performance): update Souin setup & enable Cache-Control public in docs #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for improving this, this is much appreciated! I left a comment regarding public
, then we'll be ready to merge.
By the way, the config can now be simplified: Before: {
order cache before rewrite
...
cache {
api {
souin
}
}
} After: {
cache
# ...
}
# ... |
@dunglas I followed your recommendations, tell me if everything is ok |
Thank you!! |
soyuka
pushed a commit
that referenced
this pull request
Sep 18, 2024
* feat(performance): update Souin setup & enable Cache-Control public in docs * feat(performance): simplify caddy config * feat(performance): remove http_cache public directive * feat(performance): add an example to set Cache-Control per api resource * feat(performance): remove http_cache public directive for varnish * Update performance.md --------- Co-authored-by: Laurent Bientz <[email protected]> Co-authored-by: Kévin Dunglas <[email protected]>
soyuka
pushed a commit
that referenced
this pull request
Sep 18, 2024
* feat(performance): update Souin setup & enable Cache-Control public in docs * feat(performance): simplify caddy config * feat(performance): remove http_cache public directive * feat(performance): add an example to set Cache-Control per api resource * feat(performance): remove http_cache public directive for varnish * Update performance.md --------- Co-authored-by: Laurent Bientz <[email protected]> Co-authored-by: Kévin Dunglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request updates Souin setup in docs, see dunglas/frankenphp#976 (comment)