lazily load SimulatePreloadedQuery #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-client-nextjs-docmodel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/release:pr |
size-limit report 📦
|
|
A new release has been made for this PR. You can install the package you need using one of
|
|
Version da4c6f8 here reduces the immediately shipped addition to the client bundle to 4678: function (e, t, n) {
n.d(t, {
SimulatePreloadedQuery: function () {
return o;
},
});
var r,
i = n(2265);
function o(e) {
let { options: t, result: o, children: l, queryKey: a } = e;
return (
r ||
(r = i.lazy(() =>
n
.e(997)
.then(n.bind(n, 997))
.then((e) => ({ default: e.SimulatePreloadedQuery }))
)),
i.createElement(r, { options: t, result: o, queryKey: a }, l)
);
}
}, |
|
/release:pr |
|
A new release has been made for this PR. You can install the package you need using one of
|
|
/release:pr |
#255 Bundle Size — 1.1MiB (-0.94%).b58bdf7(current) vs cee4e66 main#253(baseline) Warning Bundle contains 1 duplicate package – View duplicate packages Bundle metrics
|
| Current #255 |
Baseline #253 |
|
|---|---|---|
 Initial JS |
923.89KiB(-1.78%) |
940.58KiB |
 Initial CSS |
70B |
70B |
 Cache Invalidation |
59.24% |
0.03% |
| Chunks |
33(+3.13%) |
32 |
| Assets |
57(+1.79%) |
56 |
| Modules |
588(-1.84%) |
599 |
| Duplicate Modules |
99(-10.81%) |
111 |
| Duplicate Code |
6.23%(-17.81%) |
7.58% |
| Packages |
26 |
26 |
| Duplicate Packages |
1 |
1 |
Bundle size by type 2 changes 
1 regression 1 improvement
| Current #255 |
Baseline #253 |
|
|---|---|---|
| JS |
1.09MiB (-0.95%) |
1.1MiB |
| Other |
8.78KiB (+0.62%) |
8.73KiB |
| CSS |
70B |
70B |
Bundle analysis report Branch pr/lazy-load-SimulatePreloadedQu... Project dashboard
Generated by RelativeCI Documentation Report issue
|
A new release has been made for this PR. You can install the package you need using one of
|
|
/release:pr |
|
A new release has been made for this PR. You can install the package you need using one of
|
|
Yeah... down to ❌ this one errored |
|
/release:pr |
|
A new release has been made for this PR. You can install the package you need using one of
|
|
This version now is 4678: function (e, t, n) {
n.d(t, {
SimulatePreloadedQuery: function () {
return o;
},
});
var r,
i = n(2265),
o = (e) => (
r || (r = i.lazy(() => n.e(997).then(n.bind(n, 997)))),
i.createElement(r, { ...e })
);
}, |
|
I'm good to go with this one now, @alessbell and @jerelmiller, could one of you please take a look and give this a quick review? |
jerelmiller
approved these changes
Aug 30, 2024
phryneas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a solution for #341