Update JCTools 3.3.0 -> 3.3.1-ea, use unpadded queues #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkountis
approved these changes
Jul 1, 2022
|
build failure attributed to #2245 |
idelpivnitskiy
approved these changes
Jul 1, 2022
Motivation: JCTools 3.3.1-ea provides unpadded queue variants which remove padding intended to avoid false sharing scenarios. The padding adds significant overhead when queue sizes are small which is common for ServiceTalk's queue usage (operators that only queue when back pressure occurs, pipelining requests which isn't frequently used, ..) Modifications: - Unpadded queue variants currently only exist for the UNSAFE variants. Switch PlatformDepedent UNSAFE queues to use them.
Scottmitch
force-pushed
the
jctools_low_mem_queues
branch
from
1759879
to
864c189
Compare
|
another failure due to #2245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
JCTools 3.3.1-ea provides unpadded queue variants which remove
padding intended to avoid false sharing scenarios. The padding
adds significant overhead when queue sizes are small which is
common for ServiceTalk's queue usage (operators that only queue
when back pressure occurs, pipelining requests which isn't
frequently used, ..)
Modifications:
variants. Switch PlatformDepedent UNSAFE queues to use them.