Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: See if we can consistently repro flaky IoUringTest.ioUringIsAvailableOnLinux() #2758

Closed

Conversation

bryce-anderson
Copy link
Contributor

See if we can make #2585 consistently pop.

@bryce-anderson
Copy link
Contributor Author

Based on the failed tests, it seems that this problem is specific to IOUring.

@bryce-anderson
Copy link
Contributor Author

It looks like one of the IOUring threads is indeed still alive:

	app//io.netty.incubator.channel.uring.Native.ioUringEnter(Native Method)
	app//io.netty.incubator.channel.uring.IOUringCompletionQueue.ioUringWaitCqe(IOUringCompletionQueue.java:99)
	app//io.netty.incubator.channel.uring.IOUringEventLoop.cleanup(IOUringEventLoop.java:338)
	app//io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:1044)
	app//io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	app//io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	[email protected]/java.lang.Thread.runWith(Thread.java:1596)
	[email protected]/java.lang.Thread.run(Thread.java:1583)

This is despite the executor believing it is shutdown: isShutdown(): true
https://github.com/apple/servicetalk/pull/2758/checks?check_run_id=18681028715

@bryce-anderson bryce-anderson changed the title WIP: See if we can consistently repro the flaky test WIP: See if we can consistently repro flaky IoUringTest.ioUringIsAvailableOnLinux() Nov 15, 2023
@bryce-anderson
Copy link
Contributor Author

It turns out this is a netty bug that affects short lived loops. netty/netty-incubator-transport-io_uring#227

@bryce-anderson
Copy link
Contributor Author

We have a repro on netty directly so this is no longer necessary.

@bryce-anderson bryce-anderson deleted the bl_anderson/flaky_IOUringTest branch November 15, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant