bugfix #39
Merged
bugfix #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lepture
added a commit
that referenced
this pull request
Jul 24, 2013
| @@ -59,8 +59,7 @@ define(function(require, exports, module) { | |||
|
|
|||
| refresh: function() { | |||
| var focus = this.get('focus').year(); | |||
| var column = this.element.find('[data-role=month-column]'); | |||
| var year = column.data('year'); | |||
| var year = this.element.data('year'); | |||
There was a problem hiding this comment.
?????
you introduced a bug
There was a problem hiding this comment.
MonthColumn 的实例的 element 本身就是 [data-role=month-column]
所以原来 this.element.find('[data-role=month-column]') 找到的 element 是空的，
所以 year 也是空的，底下的判断永远为 false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refresh方法里，选择器有问题，每次选择都会 refresh 下UI