Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User plots and new metrics #111

Merged
merged 147 commits into from
Oct 8, 2023
Merged

User plots and new metrics #111

merged 147 commits into from
Oct 8, 2023

Conversation

arl
Copy link
Owner

@arl arl commented Oct 7, 2023

  • New go1.20/go1.21 metrics
  • New plots showing new go1.20/1.21 runtime/metrics:
    • GC Cycles
    • GC Scan
    • Memory classes
    • CPU classes
    • Mutex wait
  • Users can now add their own plot. For now heatmaps are not supported, but scatter, bar and stacked plots have been added.

arl added 30 commits May 2, 2023 08:37
@arl
First draft of the Endpoint structure
68aa27e
@arl
_example/default: switch to statsviz.Endpoint
6a77236
@arl
_example/chi: switch to statsviz.Endpoint
bc86b87
@arl
_example: simplify test scripts
fb48df4 
No need to create go.work file, we just copy main.go and
go.mod and perform a "go mod edit -replace" in order to pass
statsviz root.
@arl
_example/echo: switch to statsviz.Endpoint
8d7b7c0
@arl
_example/fasthttp: switch to statsviz.Endpoint
904ace5
@arl
_example/fiber: switch to statsviz.Endpoint
0ecc9ff
@arl
_example/gin: switch to statsviz.Endpoint
7ab3e91
@arl
_example/gorilla: switch to statsviz.Endpoint
b5f9dd6
@arl
_example/https: switch to statsviz.Endpoint
476368d
@arl
_example/iris: switch to statsviz.Endpoint
6d8d41d
@arl
_example/middleware: switch to statsviz.Endpoint
d340f1f
@arl
_example/mux: switch to statsviz.Endpoint
ef7b678
@arl
_example/options: switch to statsviz.Endpoint
613ab08
@arl
remove handlers.go
edba2fb
@arl
remove register.go
d945104
@arl
Adapt tests
e394056
@arl
Reorganization
43537b4
@arl
Move plot.List into Endpoint
5ef6331
@arl
internal/plot: construct List with NewList
98375cf
@arl
Improve docs
8d39b58
@arl
s/endpoint{_test}.go/statsviz{_test}.go
4e04e65
@arl
Use a 'func option', to prevent misusing the API
340f61d
@arl
internal/plot: pre-allocate plots slice
0cc0d78
@arl
internal/plot: cosmetics
2029f53
@arl
internal/plot: rewrite comment
da622ef
@arl
internal/plot: renaming
d9d9f06
@arl
internal/plot: add reserved plot names to avoid conflicts
c45812e
@arl
Cosmetics
7ef3a29
@arl
Introduce the TimeSeriesBuilder struct
d01ff28
@arl
go.mod: drop go1.19, use go1.20
eef1f23
@arl
internal/plot: cosmetics
5c8ef73
@arl
internal/plot: use literal map creation syntax
5108bf6
@arl
internal/plot: add cpu-classes (gc)
ae78d42
@arl
Update README.md
ac760a3
@arl
internal/plot: disregard /godebug metrics in TestUnusedRuntimeMetrics
4dcedd9
@arl
internal/plot: reorganize cpu-classes (gc) code
428d110
@arl
internal/plot: add mutex wait plot
321b112
@arl
Update README
eaf4c49
@arl
internal/plot: use 'foo per seconds' instead of 'foo per unit of time'
51df408
@arl
internal/plot: add gc scan plot
19fc056
@arl
Update README
a4d0997
@arl
internal/static: simplify plots.js
c5e76cd
@arl
internal/static: cosmetics
4afcadd
@arl
internal/static: cosmetics
94602d6
@arl
_example: work sometimes runs a forced GC
4d855e6
@arl
Enable stacked plots: add Subplot.Type and Layout.BarMode
ad260bf
@arl
internal/plot: make 'gc-cycles' a stacked bar plot
dd9e847
@arl
internal/plot: make 'gc-scan' a stacked bar plot
9678f65
@arl
STATSVIZ_DEBUG env var selects whether assets are embedded or from di…
50ca4bc 
…rectory

For development/debugging, STATSVIZ_DEBUG=assets=dir allows to serve
assets from the contents of the 'dir' directory.
@arl
NewServer if 2 user plots have the same name
4d202da
@arl
Enable user plots to be 'stacked' plot by exposing BarMode
476dc4e
@arl
_example/userplots: add a stacked bar plot
5854e23
@arl
Update README.md
404f53b
@arl
Update CHANGELOG.md
ce93b5b
@arl
Update CHANGELOG.md
f6abdd8
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (cca6221) 90.00% compared to head (6fb7812) 61.58%.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #111       +/-   ##
===========================================
- Coverage   90.00%   61.58%   -28.42%     
===========================================
  Files           3        2        -1     
  Lines          90      177       +87     
===========================================
+ Hits           81      109       +28     
- Misses          6       64       +58     
- Partials        3        4        +1
Files Coverage Δ
statsviz.go 77.16% <77.67%> (+8.98%) ⬆️
userplot.go 22.00% <22.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arl arl merged commit 99663ce into main Oct 8, 2023
9 checks passed
@arl arl deleted the user-plots-and-new-metrics branch October 8, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arl