Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/recreate_on_push.yaml: Fix PDF breakage #177

Closed
wants to merge 1 commit into from
Closed

.github/workflows/recreate_on_push.yaml: Fix PDF breakage #177

wants to merge 1 commit into from

Conversation

TRSx80
Copy link
Member

@TRSx80 TRSx80 commented Feb 1, 2022

Previously I had commented out auto-generation of
PDF (#176), but that
seems to have broken some Actions here, which seem to look for the
PDF.

With this I hope to fix it.

Previously I had commented out auto-generation of
PDF (#176), but that
seems to have broken some Actions here, which seem to look for the
PDF.

With this I hope to fix it.
@TRSx80
Copy link
Member Author

TRSx80 commented Feb 1, 2022

Honestly I am not 100% sure how GitHub Actions works, and my Python / YAML not the best, so I would really appreciate some more people looking at this before merging.

@TRSx80
Copy link
Member Author

TRSx80 commented Feb 1, 2022

I am starting to think that I should just undo all this and bring back PDF generation. Maybe some people use it. I did not realize we were actually publishing the produced PDF.

@igorpecovnik
Copy link
Member

igorpecovnik commented Feb 1, 2022

I have disable Actions automation here since we don't need it anymore. website is generate elsewhere i think.

@TRSx80 TRSx80 closed this Feb 1, 2022
@TRSx80
Copy link
Member Author

TRSx80 commented Feb 1, 2022

I am abandoning this, because I don't think it was a good idea in the first place.

But in the meantime, I do not think that pushing to docs now will automatically re-generate them. I guess I can test that, but...

website is generate elsewhere i think

Are you sure? I don't think so, at least not based on the error I was looking at from the runner (gone, now that Actions are turned off), as well as observing previous behavior (which seem to update docs site a little while after a merge).

@igorpecovnik
Copy link
Member

I do not think that pushing to docs now will automatically re-generate them.

They are generated in cronjob. Every 10 or 15m. Something like that. Not the best, but ... it works.

@TRSx80
Copy link
Member Author

TRSx80 commented Feb 1, 2022

OK I will test. Maybe you are right after all, I did notice there is some delay. But that would be good enough. Thanks.

@TRSx80 TRSx80 deleted the fix_pdf_breakage branch February 1, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants