Skip over printers with no PPD when trying to auth for the first time. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we try to auth with a printer with no PPD, we end up getting: > cups.IPPError: (1030, u'Not Found') When we try to call the .ppd endpoint on the CUPS server (getPPD(printer_name)), which causes us to die with a non-useful error message. With this change we will skip over any printers with no PPD file and auth with the first one that has one.
|
It seems that travis won't let me see the build log to see what failed. From testing locally, I think it's due to unrelated flake8 failure around line 340 (https://github.com/armooo/cloudprint/blob/master/cloudprint/cloudprint.py#L340):
but this is outside the scope of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we try to auth with a printer with no PPD, we end up getting:
When we try to call the .ppd endpoint on the CUPS server (getPPD(printer_name)), which causes us to die with a non-useful error message.
With this change we will skip over any printers with no PPD file and auth with the first one that has one, if none are found then exit.
Possibly related to #126 and #123