Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(main) Remove commons-io exclusion from Dependabot #713

Conversation

abelsromero
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
commons-io hasn't been part of the Maven runtime for a long, long time. So we can manage ourselves as a direct plugin dependency.

Are there any alternative ways to implement this?

no

Are there any implications of this pull request? Anything a user must know?

no

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

The dependency is not part of Maven runtime, which means
we can bump as needed
@abelsromero abelsromero merged commit ea3cf9c into asciidoctor:main Jan 1, 2024
18 of 19 checks passed
@abelsromero
Copy link
Member Author

There's definitely a flake with the javadoc test that needs attention, I'll treat it in another PR.

@abelsromero abelsromero deleted the remove-commons-io-dependabot-exclusion branch February 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant