(main) Implement parent support for tests in Xpp3DoomBuilder #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying Xpp3Doom implementation removes 'getParent' support in latest version, so we need to do keep track of the parent for our tests Fixes asciidoctor#638
abelsromero
force-pushed
the
issue-638-workaround-unsupported-Xpp3Dom-getParent
branch
from
310d8d3
to
fc0f011
Compare
abelsromero
deleted the
issue-638-workaround-unsupported-Xpp3Dom-getParent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
The underlying Xpp3Doom implementation removes
'getParent' support in latest version, so we need
to do keep track of the parent for our tests
Fixes #638
Are there any alternative ways to implement this?
Maybe, but the fix is simple enough to simply get it done.
Are there any implications of this pull request? Anything a user must know?
no
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc
This is for tests only, no need to report in CHANGELOG.