Test artifacts signature #725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see we can't use secrets on PRs coming from outside the repo for security reasons https://securitylab.github.com/research/github-actions-preventing-pwn-requests/. It make sense, we can explore using environment variables for this case since the key is something randomly generated and not published. |
|
Closing while working on alternatives in fork repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Verify that the generation of release artifacts (jars + signatures) works correctly.
Especially with Dependabot bumping plugins, we could break the deployment process without knowing it because we don't test the signature.
Are there any alternative ways to implement this?
We could do a full deployment (except pushing to Maven central), but I want to go step, by step. At least, for now, this removes a risk for releases.
Note that I created a
testenvironment with a test key. Just in case, this will be different from the one used for actual releases.Are there any implications of this pull request? Anything a user must know?
no
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc