Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Migrate is_equivalent_to unit tests to Markdown tests #15470

Merged
merged 4 commits into from
Jan 14, 2025
Merged

[red-knot] Migrate is_equivalent_to unit tests to Markdown tests #15470

merged 4 commits into from
Jan 14, 2025

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Part of #15397, built on top of #15469.

Test Plan

Markdown tests.

@AlexWaygood AlexWaygood added testing Related to testing Ruff itself red-knot Multi-file analysis & type inference labels Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@InSyncWithFoo InSyncWithFoo force-pushed the rk-pt-is-equivalent-to branch from aae896e to 827e895 Compare January 14, 2025 09:47
sharkdp
sharkdp approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks good to me as soon as the conflicts have been resolved.

@InSyncWithFoo InSyncWithFoo force-pushed the rk-pt-is-equivalent-to branch from 827e895 to 4596e20 Compare January 14, 2025 15:12
@MichaReiser MichaReiser removed their request for review January 14, 2025 15:23
@carljm carljm enabled auto-merge (squash) January 14, 2025 18:56
@carljm carljm merged commit aefb607 into astral-sh:main Jan 14, 2025
20 checks passed
@InSyncWithFoo InSyncWithFoo deleted the rk-pt-is-equivalent-to branch January 14, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

@carljm carljm carljm approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference testing Related to testing Ruff itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@InSyncWithFoo @carljm @sharkdp @AlexWaygood