Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Migrate bool/str/repr unit tests to Markdown tests #15534

Merged
merged 3 commits into from
Jan 16, 2025
Merged

[red-knot] Migrate bool/str/repr unit tests to Markdown tests #15534

merged 3 commits into from
Jan 16, 2025
+105 −66

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Part of #15397.

Test Plan

Markdown tests.

@InSyncWithFoo InSyncWithFoo marked this pull request as draft January 16, 2025 16:07
@AlexWaygood AlexWaygood added the red-knot Multi-file analysis & type inference label Jan 16, 2025
@InSyncWithFoo InSyncWithFoo marked this pull request as ready for review January 16, 2025 17:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser removed their request for review January 16, 2025 17:24
carljm
carljm approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!!

@carljm carljm merged commit 2e6729d into astral-sh:main Jan 16, 2025
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the rk-pt-bool-str-repr branch January 16, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InSyncWithFoo @carljm @AlexWaygood