Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-commit GitHub Action on an ARM processor #15567

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 18, 2025

Copy link
Contributor

github-actions bot commented Jan 18, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

warning: Detected debug build without --no-cache.
error: Failed to read examples/Assistants_API_overview_python.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: expected `,` or `]` at line 197 column 8

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to read examples/Assistants_API_overview_python.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: expected `,` or `]` at line 197 column 8

@MichaReiser
Copy link
Member

MichaReiser commented Jan 18, 2025

Thanks for looking into this. The pre-commit currently fails and I don't see a speedup. E.g. #15566 completed after 3 min where the run on this job failed after 4.

@MichaReiser MichaReiser added the ci Related to internal CI tooling label Jan 18, 2025
@cclauss
Copy link
Contributor Author

cclauss commented Jan 18, 2025

Can you please rerun the failing test because rhysd/actionlint#507 seems to pass.

The hooks seem to be recreated with each run so perhaps the network io time dwarfs the faster CPU.

@MichaReiser
Copy link
Member

I restarted the job but I don't think it will succeed because it seems to error because our github workflow linter doesn't recognize the new runner yet. We probably need to update it first.

@cclauss
Copy link
Contributor Author

cclauss commented Jan 18, 2025

Understood. Thanks for the re-try. We will need to wait for the ecosystem to catch up.

@cclauss cclauss closed this Jan 18, 2025
@cclauss cclauss deleted the patch-1 branch January 18, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants