Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid quadratic membership check in import fixes #15576

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Avoid quadratic membership check in import fixes #15576

merged 1 commit into from
Jan 18, 2025
+9 −11

Conversation

charliermarsh
Copy link
Member

Summary

This leads to an explosion in runtime for (admittedly absurd) cases with tens of thousands of imports.

@charliermarsh charliermarsh added the performance Potential performance improvement label Jan 18, 2025
@charliermarsh charliermarsh enabled auto-merge (squash) January 18, 2025 23:00
@charliermarsh charliermarsh merged commit b8e5b95 into main Jan 18, 2025
20 checks passed
@charliermarsh charliermarsh deleted the charlie/quad branch January 18, 2025 23:01
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance Potential performance improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliermarsh