Allow --python <dir> requests to match existing environments if sys.executable is the same file
#11290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.executable` is the same file
zanieb
commented
Feb 7, 2025
| @@ -1476,8 +1476,12 @@ impl PythonRequest { | |||
| version_request.matches_interpreter(interpreter) | |||
| } | |||
| PythonRequest::Directory(directory) => { | |||
| // `sys.prefix` points to the venv root. | |||
| // `sys.prefix` points to the environment root or `sys.executable` is the same | |||
| is_same_executable(directory, interpreter.sys_prefix()) | |||
There was a problem hiding this comment.
Arguably, we could remove this first check. Mildly afraid of something breaking though.
konstin
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11288
I tested the reproduction there manually.
I'm a little uncertain about this behavior, it's not true to the spirit of
--python <dir>selecting a target environment but this method is only used to see if an existing environment matches for the purpose of invalidation in projects and tools where I think we always force a separate environment anyway?