Validate value object required fields in the constructor #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Jul 1, 2023
| 'PROPERTY' => GeneratorHelper::normalizeName($member->getName()), | ||
| 'NAME' => $member->getName(), | ||
| 'CLASS' => $objectClass->getName(), | ||
| 'FALLBACK' => $fallback, |
There was a problem hiding this comment.
only when the class is used in Input? 🤔
Do we need to assert the content returned by the provider. Or we can blindly trust the data, and remove all this boilerplate like we do in output generated code.
There was a problem hiding this comment.
For now, I will keep the isset check for all value objects instead of changing depending on whether it is used in input. It makes the code simpler and your suggestion would not always avoid checking that for responses anyway given that some value objects are used both in input and responses.
Optional array fields still need to consider the property as nullable even though the getter will return an empty array as AWS does not treat absent lists the same than empty lists in input.
This is already validated in the constructor now.
stof
force-pushed
the
better_object_error_handling
branch
from
f788b69 to
bc0a48e
Compare
jderusse
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1481