This repository has been archived by the owner on Jan 13, 2021. It is now read-only.
Use Store to Get resources #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash2k
force-pushed
the
use-store-in-worker
branch
from
1182f68 to
382d8f1
Compare
nilebox
reviewed
Mar 24, 2017
pkg/processor/worker.go
Outdated
| @@ -157,58 +144,94 @@ func (wrk *worker) checkResource(bundle *smith.Bundle, res *smith.Resource) (isR | |||
| // UID: bundle.Metadata.UID, | |||
| //})) | |||
|
|
|||
| // 3. Create of update resource | |||
pkg/processor/worker.go
Outdated
| var ok bool | ||
| response, ok = obj.(*unstructured.Unstructured) | ||
| if !ok { | ||
| response = new(unstructured.Unstructured) |
There was a problem hiding this comment.
What's the difference between new(unstructured.Unstructured) and unstructured.Unstructured{}?
With the latter you can set the Object value inside.
There was a problem hiding this comment.
No practical difference. Already changed it locally.
Should reduce number of api calls significantly.
ash2k
force-pushed
the
use-store-in-worker
branch
from
382d8f1 to
35c8711
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should reduce number of api calls significantly.