This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add aborted bindings to the did-match-binding event #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Why keybindings act the way that they do is sometimes a mystery to Atom users. One of the ways that isn't surfaced well is when one keybinding is aborted and another is executed in its place. This change adds a list of aborted bindings to the
onDidMatchBindingevent so they can be surfaced in the keybinding-resolver package.Alternate Designs
None considered.
Benefits
People will be able to debug their keybindings better.
Possible Drawbacks
The difference between the
abort!command name and thee.abortKeyBindingfunction is also not well understood. This change may confuse some Atom users by making that difference more visible.Applicable Issues
N/A