Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian packaging #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Debian packaging #134

wants to merge 1 commit into from

Conversation

m-roberts
Copy link

No description provided.

@dvzrv
Copy link

dvzrv commented May 12, 2021

Why is this not maintained with the distribution though? It makes no sense for an upstream to maintain their own packaging build scripts (unless they want to explicitly provide prebuilt packages in a custom repository). That's what distributions are for.

You could ask the responsible teams in the respective distributions to package it (e.g. multimedia team with debian or fedora).

@attwad
Copy link
Owner

attwad commented May 12, 2021

Thank you for the PRs. Can you please explain why having a debian package is better than relying on pip or whatever package manager you prefer to install this library? I'm trying to keep things simple here as I maintain this on a best effort and I'm definitely not versed in debian packaging hence my question, thank you.

@m-roberts
Copy link
Author

Why is this not maintained with the distribution though? It makes no sense for an upstream to maintain their own packaging build scripts (unless they want to explicitly provide prebuilt packages in a custom repository). That's what distributions are for.

You could ask the responsible teams in the respective distributions to package it (e.g. multimedia team with debian or fedora).

We have this hosted on our fork, and will be using that as the basis for our own distribution if upstream does not want to manage additional packaging. However, I wanted to offer the chance to review the code change - hence this PR!

Thank you for the PRs. Can you please explain why having a debian package is better than relying on pip or whatever package manager you prefer to install this library? I'm trying to keep things simple here as I maintain this on a best effort and I'm definitely not versed in debian packaging hence my question, thank you.

On Debian-based systems, it is encouraged to make use of Debian packages for Python modules where possible.

The best case scenario would be that this packaging gets accepted by the team at Debian, Ubuntu, etc. that would be responsible for maintaining it in their repository for their particular distribution.

For users like myself, easily being able to package a Python module for Debian-based operating is much appreciated!

The actual maintenance is pretty low - just the changelog needs to be updated with a new release. Given that this is a mature, stable offering, it seems that this will be infrequent at most.

It's really up to you whether you want to handle it or not. You could, if you wish, direct people to our fork if they are looking for a Debian package for the module. Unfortunately, we wouldn't be able to guarantee keeping it up-to-date in the same way as if it were included as an additional build artifact alongside the Python wheel.

@m-roberts
Copy link
Author

The simplest way to support building the Debian package in CI should be as simple as including the action-debian-package action in a GitHub Actions workflow.

@m-roberts
Copy link
Author

m-roberts commented Jun 1, 2021

You may also prefer simply directing users to our own hosting of these packages: https://github.com/pi-top/python-osc-deb/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants