Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic when invoking delete on empty tui #2584

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

tessus
Copy link
Contributor

@tessus tessus commented Feb 14, 2025

If the result set is empty and thus the TUI does not show any entries, a panic occurs when a user invokes 'delete' via Prefix (Ctrl-A) d or Ctrl-D in the inspector..

image

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

If the result set is empty and thus the TUI does not show any entries,
a panic occurs when a user invokes 'delete' via Prefix Ctrl-D or Ctrl-D
in the inspector..
@tessus
Copy link
Contributor Author

tessus commented Feb 16, 2025

Not sure what's up with the macos14 pipeline. It didn't fail. It was cancelled.

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 🙏

@ellie ellie merged commit c55ea10 into atuinsh:main Feb 19, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants