Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negadoctor : Introduce slide film mode #425

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Jiyone
Copy link
Collaborator

@Jiyone Jiyone commented Feb 4, 2025

After testing it for several weeks, I propose this positive film editing mode into Negadoctor.
This feature allows users to edit their scans of slide film and easily restore exposure issues (especially in high and low density color balance).

  • The GUI adapts based on the selected mode (negative or positive).
    Since slide film is not inverted, the color balance settings are reversed between shadows and highlights compared to the negative mode, in order to consistently represent low and high densities across all modes. Parameter names are automatically updated in the Corrections tab, and tooltips are adjusted throughout.

  • The calculations for the automatic adjustments of the color balance pipettes for high densities, as well as Paper Black and Print Exposure, have been adapted to work correctly in positive mode.

Note:

As for negative film, the user needs to measure the film base with Dmin and the highest density area with Dmax.
In positive mode, Shadow / Highlight color balance are inverted. So in slide film mode, the corrective color balance bias in highlights (offset) should be done first, if any, and then the general color balance is made ideally in shadows (gain).

TODO :

  • Since keyboard shortcuts name are settings name sensitive, I think I'll rewrite the two functions that renames settings depending of negative or positive film mode. Maybe unify the names as red offset and red gain instead of shadows red offset and highlights red gain, or low red offset and high red gain.
  • Look if there is not a better optimisation to do in auto setting code.

- invert low white balance settings for slide.
- change auto high color balance, black and exposure for slide.
- change labels and tooltips text depending on film stock.
@Jiyone Jiyone changed the title Neg ciba Negadoctor : Introduce slide film mode Feb 4, 2025
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
27.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@aurelienpierre aurelienpierre added this to the 1.0 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants