Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_velocity_smoother): porting from universe to core #10184

Conversation

liuXinGangChina
Copy link
Contributor

@liuXinGangChina liuXinGangChina commented Feb 21, 2025

Description

We are porting autoware_velocity_smoother to autoware.core, this PR:

  1. resolve the conflict when replace tire4 message
  2. replace autoware_universe_utils with autowre_utils
  3. resolve the conflict when complie the whole autoware
  4. refactor readme according to migrate guide

Related links

Parent Issue: -- autowarefoundation/autoware.core#192

How was this PR tested?

check box selected means passed

  • test with concol build "colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release" for all packages
  • test with planning simulator

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Feb 21, 2025
Copy link

github-actions bot commented Feb 21, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@liuXinGangChina liuXinGangChina force-pushed the velocity-smoother-migration branch from 6af889f to 516db61 Compare February 21, 2025 06:27
@liuXinGangChina liuXinGangChina self-assigned this Feb 21, 2025
@liuXinGangChina liuXinGangChina added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 32.85714% with 47 lines in your changes missing coverage. Please review.

Project coverage is 26.84%. Comparing base (3718ac9) to head (f06dbae).

Files with missing lines Patch % Lines
planning/autoware_velocity_smoother/src/node.cpp 21.05% 15 Missing ⚠️
...utoware_overlay_rviz_plugin/src/signal_display.cpp 0.00% 8 Missing ⚠️
...utoware_velocity_smoother/src/trajectory_utils.cpp 55.55% 4 Missing ⚠️
...op_operator/mrm_comfortable_stop_operator_core.cpp 0.00% 4 Missing ⚠️
...r4_planning_rviz_plugin/src/tools/max_velocity.cpp 0.00% 3 Missing ⚠️
...anning/autoware_velocity_smoother/src/resample.cpp 0.00% 0 Missing and 2 partials ⚠️
...k_constrained_smoother/velocity_planning_utils.cpp 0.00% 2 Missing ⚠️
...e_velocity_smoother/src/smoother/smoother_base.cpp 60.00% 1 Missing and 1 partial ⚠️
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% 2 Missing ⚠️
...or/src/remaining_distance_time_calculator_node.cpp 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10184   +/-   ##
=======================================
  Coverage   26.83%   26.84%           
=======================================
  Files        1398     1400    +2     
  Lines      108028   108049   +21     
  Branches    41614    41612    -2     
=======================================
+ Hits        28993    29007   +14     
- Misses      76150    76154    +4     
- Partials     2885     2888    +3     
Flag Coverage Δ *Carryforward flag
differential 26.14% <32.85%> (?)
total 26.83% <ø> (-0.01%) ⬇️ Carriedforward from 3718ac9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

liuXinGangChina and others added 4 commits February 22, 2025 11:51
…ware_velocity_smoother, update readme, replace dependency from autoware_universe_utils to autoware_utils.local test passed: v0.0

Signed-off-by: liuXinGangChina <[email protected]>
…ware_velocity_smoother, partially replace tier4 message dependency with autoware_internal message.local test passed: v0.0

Signed-off-by: liuXinGangChina <[email protected]>
…are_velocity_smoother, solve dependency conflict which use tier4 planning velocity limit msg: v0.2

Signed-off-by: liuXinGangChina <[email protected]>
@liuXinGangChina liuXinGangChina force-pushed the velocity-smoother-migration branch from 4282bdc to f06dbae Compare February 22, 2025 03:51
@liuXinGangChina
Copy link
Contributor Author

close this pr, and split it into two prs due to autowarefoundation/autoware.core#192 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant