fix: overriden mock resource outputs are respected in amplifyconfiguration #13274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phani-srikar
commented
Sep 27, 2023
| @@ -1,4 +1,4 @@ | |||
| const configHelper = require('../../amplify-frontend-android/lib/amplify-config-helper'); | |||
There was a problem hiding this comment.
We have NOT been testing iOS config generator BUT Android all this time from the iOS frontend plugin!
alharris-at
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes an issue with mocking where the local GraphQL endpoint and API key are not reflected in the
amplifyconfiguration.jsonfile when customer runsamplify mock apiin iOS/Android projects. Refer to discord customer report for more information.Issue #, if available
Description of how you validated changes
Added unit tests, check in iOS,Android samples.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.