-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(all): Updated Flutter/Dart SDKs and Drift version #5741
base: main
Are you sure you want to change the base?
Conversation
…rated pigeon -renamed setup to setUp in various locations -added pigeonVar_binaryMessenger and pigeonVar_messageChannelSuffix to AmplifyNativeLegacyWrapper -renamed PigeonLegacyDataProvider to PinpointLegacyDataProvider (API can’t start with Pigeon) -updated signInWithUrl’s return value (this was updated 3 years ago)
e75b161
to
dcbec77
Compare
@@ -93,7 +93,7 @@ As always, you can find us on [GitHub](https://github.com/aws-amplify/amplify-fl | |||
## 1.8.0 | |||
|
|||
NOTE: This version has been updated to: | |||
- Flutter: ">=3.19.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change as we should not update old changelogs unless they are incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look at the generated code but only had one question from a Kotlin perspective.
) | ||
onSuccess.accept(authSession) | ||
} else { | ||
AuthSessionResult.failure<AWSCognitoUserPoolTokens>(UnknownException("Could not fetch")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this include the upstream error?
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.