Skip to content

Commit

Permalink
Update to ACK runtime v0.39.0, code-generator v0.39.1 (#197)
Browse files Browse the repository at this point in the history
### Update to ACK runtime `v0.39.0`, code-generator `v0.39.1`

----------

* ACK code-generator `v0.39.1` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.39.1)
* ACK runtime `v0.39.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.39.0)

----------

NOTE:
This PR increments the release version of service controller from `v1.4.5` to `v1.4.6`

Once this PR is merged, release `v1.4.6` will be automatically created for `rds-controller`

**Please close this PR, if you do not want the new patch release for `rds-controller`**

----------

#### stdout for `make build-controller`:

```
building ack-generate ... ok.
==== building rds-controller ====
Copying common custom resource definitions into rds
Building Kubernetes API objects for rds
Generating deepcopy code for rds
Generating custom resource definitions for rds
Building service controller for rds
Generating RBAC manifests for rds
Running gofmt against generated code for rds
Updating additional GitHub repository maintenance files
==== building rds-controller release artifacts ====
Building release artifacts for rds-v1.4.6
Generating common custom resource definitions
Generating custom resource definitions for rds
Generating RBAC manifests for rds
```

----------

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • Loading branch information
ack-bot authored Oct 11, 2024
1 parent b8b4e75 commit ee3d577
Show file tree
Hide file tree
Showing 19 changed files with 146 additions and 1,124 deletions.
8 changes: 4 additions & 4 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ack_generate_info:
build_date: "2024-09-02T17:25:38Z"
build_hash: f8f98563404066ac3340db0a049d2e530e5c51cc
go_version: go1.22.5
version: v0.38.1
build_date: "2024-10-10T04:05:06Z"
build_hash: 36c2d234498c2bc4f60773ab8df632af4067f43b
go_version: go1.23.2
version: v0.39.1
api_directory_checksum: c6892f99dde0bc4fbc875f328cf37ededd376229
api_version: v1alpha1
aws_sdk_go_version: v1.44.232
Expand Down
2 changes: 1 addition & 1 deletion config/controller/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ kind: Kustomization
images:
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/rds-controller
newTag: 1.4.5
newTag: 1.4.6
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.14.0
controller-gen.kubebuilder.io/version: v0.16.2
name: dbclusterparametergroups.rds.services.k8s.aws
spec:
group: rds.services.k8s.aws
Expand Down Expand Up @@ -41,10 +41,8 @@ spec:
description: |-
DBClusterParameterGroupSpec defines the desired state of DBClusterParameterGroup.
Contains the details of an Amazon RDS DB cluster parameter group.
This data type is used as a response element in the DescribeDBClusterParameterGroups
action.
properties:
Expand All @@ -58,78 +56,56 @@ spec:
and can be applied only to a DB cluster running a database engine and engine
version compatible with that DB cluster parameter group family.
Aurora MySQL
Example: aurora5.6, aurora-mysql5.7, aurora-mysql8.0
Aurora PostgreSQL
Example: aurora-postgresql9.6
RDS for MySQL
Example: mysql8.0
RDS for PostgreSQL
Example: postgres12
To list all of the available parameter group families for a DB engine, use
the following command:
aws rds describe-db-engine-versions --query "DBEngineVersions[].DBParameterGroupFamily"
--engine <engine>
For example, to list all of the available parameter group families for the
Aurora PostgreSQL DB engine, use the following command:
aws rds describe-db-engine-versions --query "DBEngineVersions[].DBParameterGroupFamily"
--engine aurora-postgresql
The output contains duplicates.
The following are the valid DB engine values:
* aurora (for MySQL 5.6-compatible Aurora)
* aurora-mysql (for MySQL 5.7-compatible and MySQL 8.0-compatible Aurora)
* aurora-postgresql
* mysql
* postgres
type: string
name:
description: |-
The name of the DB cluster parameter group.
Constraints:
* Must not match the name of an existing DB cluster parameter group.
This value is stored as a lowercase string.
type: string
parameterOverrides:
Expand All @@ -140,14 +116,11 @@ spec:
description: |-
A list of parameters in the DB cluster parameter group to modify.
Valid Values (for the application method): immediate | pending-reboot
You can use the immediate value with dynamic parameters only. You can use
the pending-reboot value for both dynamic and static parameters.
When the application method is immediate, changes to dynamic parameters are
applied immediately to the DB clusters associated with the parameter group.
When the application method is pending-reboot, changes to dynamic and static
Expand All @@ -158,7 +131,6 @@ spec:
This data type is used as a request parameter in the ModifyDBParameterGroup
and ResetDBParameterGroup actions.
This data type is used as a response element in the DescribeEngineDefaultParameters
and DescribeDBParameters actions.
properties:
Expand Down Expand Up @@ -194,7 +166,6 @@ spec:
description: |-
Metadata assigned to an Amazon RDS resource consisting of a key-value pair.
For more information, see Tagging Amazon RDS Resources (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_Tagging.html)
in the Amazon RDS User Guide.
properties:
Expand Down Expand Up @@ -227,7 +198,6 @@ spec:
when it has verified that an "adopted" resource (a resource where the
ARN annotation was set by the Kubernetes user on the CR) exists and
matches the supplied CR's Spec field values.
TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
https://github.com/aws/aws-controllers-k8s/issues/270
type: string
ownerAccountID:
Expand Down Expand Up @@ -286,7 +256,6 @@ spec:
This data type is used as a request parameter in the ModifyDBParameterGroup
and ResetDBParameterGroup actions.
This data type is used as a response element in the DescribeEngineDefaultParameters
and DescribeDBParameters actions.
properties:
Expand Down
Loading

0 comments on commit ee3d577

Please sign in to comment.