Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebook to provide complex sample #472

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

zhanyany16
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@isingh09 isingh09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@isingh09 isingh09 merged commit b4e0248 into aws-samples:main Jan 29, 2025
@alvarosevilla95
Copy link

@zhanyany16 why did you remove the converse api example here? does it not work well? I imported the model yesterday with the converse tokenizer config, and it's working well except it doesn't output the opening tag. Do you know what that is?

@Sofianel5
Copy link

Sofianel5 commented Feb 1, 2025

@zhanyany16 in auto_generate - why do you add the generation to user messages (and why only to user messages, not assistant messages)? Is this example only supposed to be for the case where the input is [ { role: user, content: x } ] or will it also work for more complex and long chats? Why not use continue_final_message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants