-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lambda-nodejs): do not require a frozen lockfile for bun #32908
Open
blimmer
wants to merge
7
commits into
aws:main
Choose a base branch
from
blimmer:fix-bun
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+355
−179
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ccbd891
fix: do not require a frozen lockfile for bun
blimmer d5184d3
chore: update bun.lockb
blimmer 21196f5
chore: bump the runtime to force the test to re-run
blimmer 2962dea
docs: add comment about regenerating the lockfile
blimmer b6e3738
fix: update integration tests
blimmer fbb115c
fix: smaller package.json
blimmer a5303ab
Merge branch 'main' into fix-bun
paulhcsun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
...-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ-handlers/bun/_package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "/": "We call this _package.json so nx doesn't get confused. If you need to regenerate the lockfile, temporarily rename this file to package.json", | ||
| "//": "It's important to have two dependencies here (one bundled, one not) to test that the lockfile can be updated in the docker container.", | ||
| "dependencies": { | ||
| "axios": "1.7.8", | ||
| "express": "4.19.2" | ||
| } | ||
| } | ||
Binary file modified
BIN
+24.7 KB
(720%)
...@aws-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ-handlers/bun/bun.lockb
Binary file not shown.
12 changes: 6 additions & 6 deletions
12
...est/integ.dependencies-bun.js.snapshot/BunTestDefaultTestDeployAssert773BA602.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
...t/integ.dependencies-bun.js.snapshot/BunTestDefaultTestDeployAssert773BA602.template.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
12 changes: 6 additions & 6 deletions
12
...nteg/test/aws-lambda-nodejs/test/integ.dependencies-bun.js.snapshot/TestStack.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @rix0rrr - I see that you were working with this setup in #33022. Does this setup seem reasonable to you? I need to make sure that the lockfile will be modified during bundling to avoid the origin issue this PR fixes.