[V4] Updated EventStreams Byte to SByte to be inline with the spec where Byte was intended to be signed. #3661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
EventStreamHeaderType.Byte
toEventStreamHeaderType.SByte
to be compliant with the specification that a byte is anInt8
which is a signed 8 bit integer not an unsigned 8 bit integer. Updated unit tests and handling of the SByte.From the SPEC:
The fixed unit test should have been testing a -47 which it couldn't have done as an unsigned byte.
Motivation and Context
https://sim.amazon.com/issues/DOTNET-7943
Testing
Screenshots (if appropriate)
Types of changes
Checklist
License