docs: Update Karpenter examples to include required amiSelectorTerms #7564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update aligns the Karpenter examples with the recent changes introduced in PR aws#6450, which makes amiSelectorTerms a required field in the AWS Karpenter provider.
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
engedaam
reviewed
Jan 7, 2025
| @@ -77,6 +77,10 @@ For example, you could have: | |||
| spec: | |||
| # The latest AMI in this family will be used | |||
| amiFamily: AL2 | |||
| amiSelectorTerms: | |||
| @@ -77,6 +77,10 @@ For example, you could have: | |||
| spec: | |||
There was a problem hiding this comment.
Linking the line here since I can't comment on it. Seems like the Paragraph above this example needs to be updated:
Test clusters: On lower environment clusters, you can run the latest AMIs for your workloads in a safe environment. The EC2NodeClass for these clusters could be set with a chosen amiFamily, but no amiSelectorTerms set. For example, the NodePool and EC2NodeClass could begin with the following:
Pull Request Test Coverage Report for Build 12600603492Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@d1egoaz Any updates here? |
|
Closing this PR in favor: #7582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update aligns the Karpenter examples with the recent changes introduced in PR #6450, which makes
amiSelectorTermsa required field inNodeClasses.How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.