feat: make instanceTypeFlexibilityThreshold configurable
#7741
+65
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -222,7 +221,7 @@ func (p *DefaultProvider) launchInstance(ctx context.Context, nodeClass *v1.EC2N | |||
| reason, message := awserrors.ToReasonMessage(err) | |||
| return ec2types.CreateFleetInstance{}, cloudprovider.NewCreateError(fmt.Errorf("getting launch template configs, %w", err), reason, fmt.Sprintf("Error getting launch template configs: %s", message)) | |||
| } | |||
| if err := p.checkODFallback(nodeClaim, instanceTypes, launchTemplateConfigs); err != nil { | |||
| if err := p.checkODFallback(ctx, nodeClaim, instanceTypes, launchTemplateConfigs); err != nil { | |||
| log.FromContext(ctx).Error(err, "failed while checking on-demand fallback") | |||
There was a problem hiding this comment.
Maybe this error message should be updated because it might be confusing -- this shouldn't prevent it from launching OD in this scenario so I don't see a reason for surfacing this as an option if it doesn't tangibly affect the business logic, only the logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
--instance-type-flexibility-threshold/INSTANCE_TYPE_FLEXIBILITY_THRESHOLDwith same default value of 5.How was this change tested?
only basic functionality testing done
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.