ci: change rust-toolchain format to toml #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
approved these changes
Jan 28, 2025
jmayclin
approved these changes
Jan 30, 2025
| @@ -327,15 +333,22 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| submodules: true | |||
|
|
|||
| - uses: SebRollen/[email protected] | |||
There was a problem hiding this comment.
Suggested change
| - uses: SebRollen/toml-action@v1.2.0 | |
| - uses: SebRollen/toml-action@v1 |
Nit: Let's just specify the major version. Otherwise dependabot will open a PR for every patch update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
part of #4986
Description of changes:
When testing #5065, I discovered the cargo run for
restricted-MSRVfailed due to this dependency parse error, saying the non-TOML rust-toolchain format was deprecated by Rust. This format is also being used in two other CI jobs:clippyandmsrv. This PR is meant to replace the plain rust-toolchain files with TOML.Commit breakdown:
Check MSRVcommands with the value parsed fromrust-toolchain.tomlrust-toolchainfiles withrust-toolchain.tomlinextended,standard, andstandard/benchfoldersCall-outs:
None
Testing:
The two affected CI jobs (
clippyandmsrv) succeeded with this PR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.