feat: Add binpacking examples #615
Conversation
There was a problem hiding this comment.
Thanks for the doc @hitsub2 ! Please check the comments.
Could you please elaborate this doc like a blog and talk about the problem, solution and pros and cons of maintaining this custom scheduler. How the upgrades are managed with this scheduler etc.
| @@ -0,0 +1,56 @@ | |||
| --- | |||
There was a problem hiding this comment.
Could you move this file under resources section? https://github.com/awslabs/data-on-eks/tree/main/website/docs/resources
| ```bash | ||
| kind: Pod | ||
| spec: | ||
| schedulerName: my-scheduler |
There was a problem hiding this comment.
Let's give the name as custom-k8s-scheduler
There was a problem hiding this comment.
Neuron scheduler deployment is also using the same name :)
|
|
||
|
|
||
| ## Deploying the Solution | ||
| Please follow [this link](https://github.com/aws-samples/custom-scheduler-eks) to deploy the custom scheduler. |
There was a problem hiding this comment.
Can you add the deployment step directly here and ask the users to refer to the aws-samples project for more details.
Also, please explain more details of any caution that users needs to be aware while deploying this scheduler
There was a problem hiding this comment.
There is a section called considerations, but indeed we should give the adoption guidance for the users
|
|
||
| # Binpacking for Amazon EKS | ||
|
|
||
| ## Introduction |
There was a problem hiding this comment.
Let's talk little bit more about the problem statement and what is "LeastAllocated" and "MostAllocated". It would be nice to show the difference in images if you have any.
There was a problem hiding this comment.
Move these images also under resources section
There was a problem hiding this comment.
making new folder called img under resources
yes, thanks for the comment. Will add more details around these. |
| ``` | ||
|
|
||
|
|
||
| ## Verfication and Monitor via [eks-node-viewer](https://github.com/awslabs/eks-node-viewer) |
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Issue: 614
Motivation
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes