#205-jason-bbdd #233
Open
#205-jason-bbdd #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rucev
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Hay que hacer algunas correcciones/cambios antes de mergear:
- El nombre de la PR debería ser
#205-JSON-BBDDpara que siga el patrón que propuso Ventu. - Los archivos de
array-stand-aloneno deberías incluirlos en está PR. - Faltan los tests (estan los archivos pero no tienen código).
- En el
package.jsonel comandonpm run list-usersno referencia a ningún archivo porque el archivo de interface esta guardado comolist-user.jsen singular. Deberías cambiar el nombre alist-users.jspara que funcione sin problemas.
El resto funciona genial si lo testeas manualmente, así que con estos cambios ya estaría listo para mergear ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR ready for merging.