Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the blank lines when entering fullscreen on Yosemite #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vestimir
Copy link

I did a little re-arrangement of the methods, that are called during the fullscreen animation and it's almost working.

The problem: When the animation finishes a gray line appears on the right side of the screen. Call to [self resizeWindowToFitContentSize:[vimView desiredSize] keepOnScreen:YES]; at the end of all animations fixes it, but still for a second there's an annoying blink. If anyone has any clues how to fix this, it will be great.

annoying_grey_column

@vestimir vestimir mentioned this pull request Nov 15, 2014
4 tasks
@krid78
Copy link

krid78 commented Nov 15, 2014

Yeah! Great! This seems to work. I see the grey column as well, but better than missing the first line in FS mode ;)

@dhilipsiva
Copy link

Any ideas when will this PR or PR #45 be merged? I always work in full-screen mode. This is great help. Thanks for @vestimir and @zenangst for the fixes :) 👍

@benoitc
Copy link

benoitc commented Dec 24, 2014

any news about it ?

@jonashaag
Copy link

Does anyone know of a actively maintained MacVim fork?

@kopischke
Copy link

@jonashaag try @amadeusfork, specifically the yosemite-cherry-picked branch.

@jonashaag
Copy link

Hm, neither the fix in this PR nor the fix here benoitc@9f77ac3 works for me...

@krid78
Copy link

krid78 commented Jan 12, 2015

Well, I tried @amadeus’ fork yesterday in the evening and it did not work form me, either. I had move some lines of code. Now it looks more like the version from @vestimir. I put this on Github.

@jonashaag
Copy link

Hm, that didn't work either. I have version that works for me here: https://github.com/jonashaag/macvim/tree/yosemite

I also set up automatic builds that you can download here: https://github.com/jonashaag/macvim/releases

Maybe I'll also start integrating upstream vim patches / accept other patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants