Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limits end to end buffering in gridconnect bridge. #758

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Limits end to end buffering in gridconnect bridge. #758

merged 2 commits into from
Dec 31, 2023

Conversation

balazsracz
Copy link
Collaborator

When a dispatcher is used to send traffic to a gridconnect bridge, an infinite number of packets were allocated in the dispatcher when more than one client was connected. This is a typical situation when a hub is operating.

By adding a limitedpool to the bridge object, we can ensure that the dispatcher is blocked when the output queue is full and pushes back.

This PR respects the config option gridconnect_bridge_max_outgoing_packets.

@balazsracz
Limits end to end buffering in gridconnect bridge.
4bd04c6 
When a dispatcher was used to send traffic to a gridconnect bridge,
an infinite number of packets were allocated in the dispatcher when more than
one client was connected.

By adding a limitedpool to the bridge object, we can ensure that the dispatcher is blocked when
the output queue pushes back.
@balazsracz
fix whitespace
46cfb1c
@balazsracz balazsracz requested a review from bakerstu December 29, 2023 09:57
bakerstu
bakerstu approved these changes Dec 30, 2023
View reviewed changes
Copy link
Owner

@bakerstu bakerstu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Simple and flexible.

@balazsracz balazsracz merged commit f7f6206 into master Dec 31, 2023
4 checks passed
@balazsracz balazsracz deleted the bracz-hub-bridge-limit-pool branch December 31, 2023 11:37
balazsracz added a commit that referenced this pull request Jan 1, 2024
@balazsracz
Merge branch 'master' into bracz-direct-hub-router
9864e0b 
# Via GitHub
* master:
  Adds configuration options for TCP sockets, tuning for Hub app. (#759)
  Limits end to end buffering in gridconnect bridge. (#758)
  Ensures that an executor thread can not be created twice. (#757)
  Fixes build_bootloader_img.py. (#755)

# Conflicts:
#	src/utils/sources
balazsracz added a commit that referenced this pull request Jan 2, 2024
@balazsracz
Merge branch 'master' into bracz-optimize-tcp-socket
781184c 
* master:
  Adds configuration options for TCP sockets, tuning for Hub app. (#759)
  Limits end to end buffering in gridconnect bridge. (#758)
  Ensures that an executor thread can not be created twice. (#757)
  Fixes build_bootloader_img.py. (#755)
balazsracz added a commit that referenced this pull request Jan 2, 2024
@balazsracz
Merge branch 'bracz-optimize-tcp-socket' into bracz-hub-test-app
e6b99c6 
* bracz-optimize-tcp-socket:
  Adds configuration options for TCP sockets, tuning for Hub app. (#759)
  Limits end to end buffering in gridconnect bridge. (#758)
  Ensures that an executor thread can not be created twice. (#757)
  Fixes build_bootloader_img.py. (#755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakerstu bakerstu bakerstu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balazsracz @bakerstu