BLE Basic Infrastructure #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Removes unnecessary includes that might not exist on an embedded compiler. Fix compilation of TempFile under esp8266. Add libatomic to esp8266 nonos target. Fix compile errors in time_client app.
- Handles the case when the src or dst buffer is empty. - Detects when the append happens exactly at a buffer boundary and the buffers are already linked buffer. - Adds a parameter that makes this work even when the link is not there yet
This fixes a buffer refcount bug when a buffer ended up with a zero length and too few refs.
- MTU < 500. - do_write needs to be repeated, so we call it via the executor.
We took over o.free_ but this makes the current buffer appendable, which is wrong.
atanisoft
reviewed
Jul 14, 2024
src/openlcb/BLEHubPort.hxx
Outdated
| @@ -60,6 +62,10 @@ public: | |||
| /// | |||
| using SendFunction = std::function<void(const uint8_t *data, size_t len)>; | |||
|
|
|||
| /// How big can a single attribute write be? ESP's BLE implementation says | |||
| /// 600 bytes. We keep some buffer. | |||
| static constexpr size_t MAX_BYTES_PER_WRITE = 500; | |||
There was a problem hiding this comment.
fyi, ble core specification is 512b. I'd likely drop to ~450b as a default (or move to a config constant)
There was a problem hiding this comment.
There is apparently also an MTU negotiation happening after the connection gets established. So this likely won't work just as is. Then the negiatiated MTU is not the maximum value that you can transmit, because there is some protocol headers as well.
Keeping iterators in a vector is not allowed when erase is used.
# Conflicts: # src/utils/DataBuffer.cxxtest # src/utils/DataBuffer.hxx
balazsracz
approved these changes
Oct 27, 2024
balazsracz
added a commit
that referenced
this pull request
Jan 16, 2025
* master: (76 commits) Fixes some compile errors in nucleo and bracz.acc. ESP-IDF CMakeLists (#800) BLE Basic Infrastructure (#788) Handles unhandled-addressed-messages by generating an OIR reply. (#798) Adds factory reset handler to linux:io_board. (#797) Fixes a standards compliance issue with the alias conflict handler. (#793) Bug fixes in DataBuffer (#791) Fixes race conditions in HubDeviceSelect. (#795) Fixes missing translation of enums when reading the security mode from a simplelink profile. (#796) Fixes flaky IfCanStress.test. (#794) Pin esp32 platform to 2.0.x (#792) Fixes detecting EOF in the memory config protocol handler. (#789) Adds a new hub application using DirectHub (#761) High-performance hub component for dealing with many sockets and high throughput (#760) Fix build of esp8266 train implementation. Removes unnecessary includes that might not exist on an embedded compiler. Fix compilation of TempFile under esp8266. Add libatomic to esp8266 nonos target. Fix compile errors in time_client app. Fixes in file memory space: (#786) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds manufacturer-independent infrastructure for a BLE-based connection protocol, and OpenLCB's implemnentation classes and constants.
Since this is all manufacturer-independent, there are no external dependencies involved, but it also means that in itself, this basic infrastructure does not work. A significant amount of additional code is needed to tie this todether with a specific manufacturer's BLE stack.
Misc changes: