Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SUNLU filaments for Bambu Lab printers #5675

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

RikshaDriver
Copy link
Contributor

Added SUNLU PLA Matte, PLA+, PLA+ 2.0, Silk PLA+, Wood PLA, Marble PLA and PETG filaments for Bambu Lab printers

@RikshaDriver
Copy link
Contributor Author

FYI @lanewei120 @QingZhangBambu @XunZhangBambu these changes have now been merged into Orca Slicer

SoftFever/OrcaSlicer#7890

@Misiu
Copy link

Misiu commented Jan 29, 2025

@RikshaDriver any chances you could add PETG High Speed filament (https://www.sunlu.com/products/high-speed-matte-petg-3d-printer-filament-1kg)?
It's quite new, but it looks very promising.

@RikshaDriver
Copy link
Contributor Author

@RikshaDriver any chances you could add PETG High Speed filament (https://www.sunlu.com/products/high-speed-matte-petg-3d-printer-filament-1kg)? It's quite new, but it looks very promising.

I've only added filaments that I have obtained and validated to some degree. The Matte PETG hasn't quite made its way to Australia as yet but you might be able to tweak the standard PETG profile.

Also @lanewei120 @QingZhangBambu @XunZhangBambu have yet to approve and merge the SUNLU filaments in this pull request

@QingZhangBambu
Copy link
Collaborator

@RikshaDriver Sorry for the late reply. I will deal with this issue in the next few days.

@RikshaDriver
Copy link
Contributor Author

Thank you.

I've just updated some parameters based on SUNLU's 2024 Technical Data Sheets

@QingZhangBambu
Copy link
Collaborator

@RikshaDriver
there are duplicate setting_id
image

@RikshaDriver
Copy link
Contributor Author

@RikshaDriver there are duplicate setting_id image

Good pickup! Have fixed and pushed upstream

@QingZhangBambu
Copy link
Collaborator

@RikshaDriver
these files should write the correct sub-path on the BBL.json file
image

@QingZhangBambu
Copy link
Collaborator

@RikshaDriver
you may use wrong name of base file
img_v3_02je_22ea59f8-62e0-491f-ab2f-b9f5b2465d5g


@RikshaDriver
Copy link
Contributor Author

Yes this was typo. I have fixed BBL.json so that name is consistent as "PLA Marble". Files have not been renamed

@QingZhangBambu
Copy link
Collaborator

@RikshaDriver
a duplicate setting id
image

@RikshaDriver
Copy link
Contributor Author

Fixed now thanks

@Misiu
Copy link

Misiu commented Feb 12, 2025

@RikshaDriver can I manually add those profiles somewhere to check them with the current version of Studio? Any hints on that?
I have PETG and I'd like to try it on A1.

Copy link
Collaborator

@QingZhangBambu QingZhangBambu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Passed tests @lanewei120

@QingZhangBambu
Copy link
Collaborator

@Misiu you could add custom filament
image

@Misiu
Copy link

Misiu commented Feb 13, 2025

@Misiu you could add custom filament image

I'm aware if that, but I was thinking that I can copy files from this PR, put them in my file system and that the new filament will appear in app

@RikshaDriver
Copy link
Contributor Author

@Misiu you could add custom filament image

I'm aware if that, but I was thinking that I can copy files from this PR, put them in my file system and that the new filament will appear in app

On Windows copy BBL.json to %AppData%\BambuStudio\system\
Then copy the SUNLU filament folder to %AppData%\BambuStudio\system\BBL\filament\

@Misiu
Copy link

Misiu commented Feb 13, 2025

On Windows copy BBL.json to %AppData%\BambuStudio\system\ Then copy the SUNLU filament folder to %AppData%\BambuStudio\system\BBL\filament\

Thank you, this works. Previously I tried adding files to C:\Program Files\Bambu Studio\resources\profiles\BBL\filament, but %AppData% folder was the key!

I only added two entries to BBL.json if anyone wan't to try only PETG

        {
            "name": "SUNLU PETG @base",
            "sub_path": "filament/SUNLU/SUNLU PETG @base.json"
        },
		{
            "name": "SUNLU PETG @BBL A1",
            "sub_path": "filament/SUNLU/SUNLU PETG @BBL A1.json"
        },

image

@QingZhangBambu
Copy link
Collaborator

@RikshaDriver Could you combine these changes into one commit to keep the record concise and organized?

@RikshaDriver RikshaDriver force-pushed the master branch 2 times, most recently from 2bdd7e5 to 882bd96 Compare February 13, 2025 21:52
@RikshaDriver
Copy link
Contributor Author

@RikshaDriver Could you combine these changes into one commit to keep the record concise and organized?

Squashed all into one commit

@QingZhangBambu
Copy link
Collaborator

@lanewei120 passed preset tests.

@Misiu
Copy link

Misiu commented Feb 14, 2025

I tested the PETG profile yesterday, Works perfectly. Thank you!

@Misiu
Copy link

Misiu commented Feb 18, 2025

@QingZhangBambu can this be merged? Just minutes ago new beta was released. I hope this will be added to the next release.
@RikshaDriver finally High Speed PETG filament is finally available to order in Poland, I'm waiting for it to arrive. I already have the Technical Data Sheet from SUNLU support, but I'd like to test the presets before I create PR with it, but only after this one gets merged.

@lanewei120 lanewei120 merged commit 3f5ccac into bambulab:master Feb 18, 2025
2 checks passed
@lanewei120
Copy link
Collaborator

thanks for doing this

@zzz-x
Copy link

zzz-x commented Feb 21, 2025

@RikshaDriver Thanks for your PR. To standardize the ID format in the code, we have modified the filament_id and setting_id in your code

@RikshaDriver
Copy link
Contributor Author

RikshaDriver commented Feb 21, 2025

@RikshaDriver Thanks for your PR. To standardize the ID format in the code, we have modified the filament_id and setting_id in your code

@zzz-x what is the proposed filament_id and setting_id moving forward?

My intent was to have a standardized format because I have noticed overlap of filament_id and setting_id parameters across all the family of slicers (i.e. OrcaSlicer and derivatives).

The intent was to set a standard such as:

filament_id : XXXzz

  • XXX = 3 code reference to vendor
  • zz = unique ID

setting_id: XXXyAA(_bb)

XXX = 3 code reference to vendor
y = Filament setting code (i.e. P for PLA or S for setting)
AA = Unique parent setting ID for Printer
bb = Optional child setting ID for nozzle variant

The AMS also appears to have limitations with filament & setting ID formats, so this seems the safest option.

Keen to get BBL and @SoftFever view on a standards-based approach to filament settings.

@QingZhangBambu
Copy link
Collaborator

I will write a standardize format rule later. a bit busy now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants