-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SUNLU filaments for Bambu Lab printers #5675
Conversation
FYI @lanewei120 @QingZhangBambu @XunZhangBambu these changes have now been merged into Orca Slicer |
@RikshaDriver any chances you could add PETG High Speed filament (https://www.sunlu.com/products/high-speed-matte-petg-3d-printer-filament-1kg)? |
I've only added filaments that I have obtained and validated to some degree. The Matte PETG hasn't quite made its way to Australia as yet but you might be able to tweak the standard PETG profile. Also @lanewei120 @QingZhangBambu @XunZhangBambu have yet to approve and merge the SUNLU filaments in this pull request |
@RikshaDriver Sorry for the late reply. I will deal with this issue in the next few days. |
Thank you. I've just updated some parameters based on SUNLU's 2024 Technical Data Sheets |
@RikshaDriver |
Good pickup! Have fixed and pushed upstream |
@RikshaDriver |
@RikshaDriver |
Yes this was typo. I have fixed BBL.json so that name is consistent as "PLA Marble". Files have not been renamed |
@RikshaDriver |
Fixed now thanks |
@RikshaDriver can I manually add those profiles somewhere to check them with the current version of Studio? Any hints on that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Passed tests @lanewei120
@Misiu you could add custom filament |
I'm aware if that, but I was thinking that I can copy files from this PR, put them in my file system and that the new filament will appear in app |
On Windows copy BBL.json to |
Thank you, this works. Previously I tried adding files to I only added two entries to BBL.json if anyone wan't to try only PETG
|
@RikshaDriver Could you combine these changes into one commit to keep the record concise and organized? |
2bdd7e5
to
882bd96
Compare
Squashed all into one commit |
…A and PETG filaments for Bambu Lab printers
@lanewei120 passed preset tests. |
I tested the PETG profile yesterday, Works perfectly. Thank you! |
@QingZhangBambu can this be merged? Just minutes ago new beta was released. I hope this will be added to the next release. |
thanks for doing this |
@RikshaDriver Thanks for your PR. To standardize the ID format in the code, we have modified the filament_id and setting_id in your code |
@zzz-x what is the proposed filament_id and setting_id moving forward? My intent was to have a standardized format because I have noticed overlap of filament_id and setting_id parameters across all the family of slicers (i.e. OrcaSlicer and derivatives). The intent was to set a standard such as:
XXX = 3 code reference to vendor The AMS also appears to have limitations with filament & setting ID formats, so this seems the safest option. Keen to get BBL and @SoftFever view on a standards-based approach to filament settings. |
I will write a standardize format rule later. a bit busy now |
Added SUNLU PLA Matte, PLA+, PLA+ 2.0, Silk PLA+, Wood PLA, Marble PLA and PETG filaments for Bambu Lab printers