fix(pivot): only use unique classes in the pivot union (Fixes #1606) #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@barryvdh I saw that you're planning to remove the CHANGELOG.md. I ignored it in this PR to avoid any conflicts. |
pataar
force-pushed
the
avoid_duplicate_class_names
branch
2 times, most recently
from
62b502d
to
8806fe5
Compare
pataar
force-pushed
the
avoid_duplicate_class_names
branch
from
b756dd7
to
9e17811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes sure that we won't add a class that's already present in the union type for pivots. This can happen when multiple relations use the same Pivot class.
Type of change
Checklist
composer fix-style