Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch React.PropTypes to PropTypes package #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leecrossley
Copy link

React.PropTypes was deprecated in React 15.x and removed from the core package in React 16.

This PR switches the implementation to use the PropTypes package, as instructed.

The change has been tested and I've also included a version bump commit for ease of publishing to npm.

@emmavault
Copy link

emmavault commented Feb 7, 2018

Hi, can anyone merge this PR? Please. @bgryszko

@paulmand3l
Copy link

Plz just merge this and release

andrew-nguyen added a commit to andrew-nguyen/react-native-circular-slider that referenced this pull request Jun 11, 2018
@Loag
Copy link

Loag commented Oct 4, 2018

is this going to ever be merged..?

@KPS250
Copy link

KPS250 commented Apr 4, 2019

Any update on these changes getting merged? I am unable to use this library due to proptypes error

@VitorBrangioni
Copy link

Merge to master, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants