update testing instructions #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closed and reopened PR to rerun CI, it seems a bit flaky as different workflows fail each time |
|
Thank you for the fix! Much appreciated. The pypy tests sometimes don't work for some reason. I haven't yet figured out what causes it exactly, seems to be concurrency-related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while working on PRs that
python setup.py testdoesn't run any tests anymore. This is due to the change that happened in this PR. Here I'm just updating the instructions to run the test the same way as the CI runs them. Also updating the instructions for running coverage as they didn't work the way they were before.