Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/KBDEV-1143: Ensembl loader not show displayName correctly #65

Conversation

sshugsc
Copy link
Contributor

@sshugsc sshugsc commented Dec 13, 2023

When running the refseq and ensembl loader, the displayName is same as the name column, which should be [sourceId.toUpperCase()].[sourceIdVersion].
Figured out it is because the fetchDisplayName function returns the content.name by default.
Tested with some refseq and ensembl records:

orientdb {db=test_shirley5}> select sourceId, displayName, name from Feature where source.displayName="RefSeq" and deletedAt is null limit 5
+----+------------+------------+------------+
|#   |sourceId    |displayName |name        |
+----+------------+------------+------------+
|0   |nm_001006118|NM_001006118|nm_001006118|
|1   |np_055391   |NP_055391   |np_055391   |
|2   |np_620310   |NP_620310   |np_620310   |
|3   |np_620311   |NP_620311   |np_620311   |
|4   |np_001185747|NP_001185747|np_001185747|
+----+------------+------------+------------+

orientdb {db=test_shirley5}> select displayName, sourceId, sourceIdVersion, name from Feature where source.displayName="Ensembl" and deletedAt is null order by createdAt desc limit 5
+----+---------------+-----------------+---------------+---------------+
|#   |sourceId       |displayName      |sourceIdVersion|name           |
+----+---------------+-----------------+---------------+---------------+
|0   |enst00000361789|ENST00000361789  |               |enst00000361789|
|1   |enst00000361789|ENST00000361789.2|2              |enst00000361789|
|2   |ensg00000198727|ENSG00000198727  |               |ensg00000198727|
|3   |ensg00000198727|ENSG00000198727.2|2              |ensg00000198727|
|4   |enst00000361681|ENST00000361681  |               |enst00000361681|
+----+---------------+-----------------+---------------+---------------+

@sshugsc sshugsc self-assigned this Dec 13, 2023
@sshugsc sshugsc merged commit 1339729 into develop Dec 13, 2023
11 checks passed
Copy link

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1339729. ± Comparison against base commit af3e76e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants