Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KBDEV-1189 Fix Redoc #69

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

bnguyen-bcgsc
Copy link
Contributor

  • Fix redoc issue where swagger json had undefined ref in components/schemas, causing render failure
  • Make constant SCHEMA_PREFIX usage more consistent
  • Rearrange stub components to stay in line with swagger official json format
  • Update redoc cdn to latest version (currently 2.1.0)

- Fix redoc issue where swagger json had undefined ref in components/schemas, causing render failure
- Make constant SCHEMA_PREFIX usage more consistent
- Rearrange stub components to stay in line with swagger official json format
- Update redoc cdn to latest version (currently 2.1.0)
@bnguyen-bcgsc bnguyen-bcgsc added the bug Something isn't working label Mar 19, 2024
@bnguyen-bcgsc bnguyen-bcgsc self-assigned this Mar 19, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.30%. Comparing base (38a7bb1) to head (8ebdc2d).

Files Patch % Lines
src/routes/openapi/index.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #69   +/-   ##
========================================
  Coverage    86.30%   86.30%           
========================================
  Files           40       40           
  Lines         2724     2724           
  Branches       682      682           
========================================
  Hits          2351     2351           
  Misses         321      321           
  Partials        52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnguyen-bcgsc bnguyen-bcgsc merged commit bfff36a into develop Apr 2, 2024
11 checks passed
Copy link

github-actions bot commented Apr 2, 2024

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bfff36a. ± Comparison against base commit 38a7bb1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants