Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move history=true by default from activeRidQuery() to getRoute() #71

Merged

Conversation

mathieulemieux
Copy link
Member

Moving the 'show deleted records' logic to the get route so it won't affect the delete and patch routes.

@mathieulemieux mathieulemieux self-assigned this Jun 24, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@1f483ec). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #71   +/-   ##
==========================================
  Coverage           ?   86.31%           
==========================================
  Files              ?       40           
  Lines              ?     2726           
  Branches           ?      683           
==========================================
  Hits               ?     2353           
  Misses             ?      321           
  Partials           ?       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathieulemieux mathieulemieux merged commit 0ccae10 into develop Jun 24, 2024
11 checks passed

This comment has been minimized.

2 similar comments

This comment has been minimized.

Copy link

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0ccae10. ± Comparison against base commit 1f483ec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants