feat: add NL translations #147
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JumpLink I tried to do a good thing and clean up some tech debt while I added the Dutch translations, but I got lost in what I suspect is a CommonJS/ESM hole 😭. Currently it's building but doesn't actually work. The browser says this I tried lots of things, renaming |
Update the locale package to use ES module syntax instead of CommonJS.
JumpLink
force-pushed
the
feat/add-nl-locale
branch
from
9ee39cb to
3079ef0
Compare
Refactor locale imports to use a camelCase conversion function. Update the `currentLocale` function to utilize this new function for better locale name handling. Remove unnecessary exports in locale files and ensure type definitions are generated correctly. Adjust `OptionsService` to enforce type safety in string manipulation. Update package.json to specify main, module, and exports for better module resolution.
feat(locale): Port to ESM
JumpLink
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dutch translations and move all the translations to their own package (
@beabee/locale) so they can be shared by the frontend and backend.This is part 1 of 2 in a stack: