Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: add markunmatched #4749

Closed
wants to merge 1 commit into from

Conversation

doronbehar
Copy link
Contributor

Description

Add a plugin useful for bulk importers.

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

Copy link
Contributor

@ybnd ybnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has a lot of potential as a more generic plugin -- some random thoughts:

  • Instead of only focusing on "weak" matches, the plugin could map recommendation levels to different commands.
  • These commands don't have to be limited to notifications
  • The prompt option to create a "marker file" could also be a configurable command!
    xargs -I $ touch $/beets-unmatched


def touch_unmatched(self, session, task):
for path in task.paths:
Path(path.decode('utf-8') + "/beets-unmatched").touch()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine you wanted this file to be easily visible from the terminal/file browser, but my first thought was that it should probably be hidden (i.e. .beets-unmatched).

Could be useful to make the filename configurable too.

@doronbehar
Copy link
Contributor Author

Hey and thanks for the review @ybnd!

Your points have made me think for a while about the purpose of this plugin, and I think I've reached good conclusions. In any case, I'd like to hear about use cases for the ideas you've suggested, in particular:

  • These commands don't have to be limited to notifications
  • The prompt option to create a "marker file" could also be a configurable command!

Although I am interested in hearing ideas, I tend to not want to add to many moving parts to this plugin. In fact, I was thinking even further, that perhaps what's implemented here could become an addition to the mbsubmit plugin, instead of a whole new plugin. Because all it tries to do is help making bulk imports easier. I'd be happy to get feedback for the following idea :):

Add another PromptChoice for mbsubmit.py, that will print the tracks into a File in the same format as the regular printing. The file name indeed should be configurable, as pointed out by @ybnd. This brings us sort of 1 step closer to resolve #1866.

Then, a user will be able to run something like:

picard $(dirname **/beets-unmatched)

Which will open picard with all of those unmatched directories, making it easy to bulk submitting those items. And also, the beets-unmatched file will have useful contents, which perhaps other usages will be found by users.

Eventually though, copying the addrelease.py logic from picard I mentioned in #1866, into beets will be the ideal improvement to mbsubmit plugin.

What do you think @sampsyo? Perhaps I should open a new PR with at least that idea added to mbsubmit.py?

@stale
Copy link

stale bot commented Oct 15, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@sampsyo
Copy link
Member

sampsyo commented Oct 20, 2023

I'm sorry that I don't have the bandwidth to carefully review this, but on principle, I certainly have no objection to adding that "file export" option to the mbsubmit plugin!

@stale stale bot removed the stale label Oct 20, 2023
@doronbehar
Copy link
Contributor Author

Closing this, as progress seems better at #4807 .

@doronbehar doronbehar closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants