Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #4709 #5236

Closed
wants to merge 7 commits into from
Closed

Fix for #4709 #5236

wants to merge 7 commits into from

Conversation

arogl
Copy link
Contributor

@arogl arogl commented May 8, 2024

Description

Fixes #4709.

Changelog to complete if testing works out

To Do

  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)

@arogl
Copy link
Contributor Author

arogl commented May 8, 2024

Doing further testng with #5235 enabled on windows to compare failures

@arogl
Copy link
Contributor Author

arogl commented May 8, 2024

I also noted the runners for python 3.x DO NOT run any tests apart from mypy 😢 they have been excluded.

They also no longer test the next beta version.

@arogl
Copy link
Contributor Author

arogl commented May 8, 2024

Thsi should be good of further tetsing before merging.
I'll try out on Ubuntu 24.04 (WSL), and teh latest version of as much as possible

@wisp3rwind
Copy link
Member

I also noted the runners for python 3.x DO NOT run any tests apart from mypy 😢 they have been excluded.

They also no longer test the next beta version.

yes, I realized the same yesterday, we should revisit our CI first. I also remember that we used to have a run for the next Python alpha; we should bring that back: In particular, we already know that Python 3.13 is going to break beets due to the imghdr removal.

@arogl
Copy link
Contributor Author

arogl commented May 8, 2024

Tested on fully updated Arch and Ubuntu-24.04 with #5235 set with DQS=0|1

beets/library.py Outdated Show resolved Hide resolved
test/test_library.py Outdated Show resolved Hide resolved
Copy link
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not coming back to this earlier, completely forgot about it 😞 Just one last thing missing - a description of the fix in the changelog

@@ -56,6 +56,7 @@ htmlcov/
coverage.xml
*,cover
.hypothesis/
.reports/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, nice!

@@ -166,6 +166,7 @@ New features:

Bug fixes:

* :bug:`4709`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a small description of the fix?

@arogl
Copy link
Contributor Author

arogl commented Sep 28, 2024

Reworked in another PR

@arogl arogl closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using double-quoted string literals in SQL queries
3 participants