-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #4709 #5236
Fix for #4709 #5236
Conversation
Doing further testng with #5235 enabled on windows to compare failures |
I also noted the runners for python 3.x DO NOT run any tests apart from mypy 😢 they have been excluded. They also no longer test the next beta version. |
Thsi should be good of further tetsing before merging. |
yes, I realized the same yesterday, we should revisit our CI first. I also remember that we used to have a run for the next Python alpha; we should bring that back: In particular, we already know that Python 3.13 is going to break beets due to the |
Tested on fully updated Arch and Ubuntu-24.04 with #5235 set with DQS=0|1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not coming back to this earlier, completely forgot about it 😞 Just one last thing missing - a description of the fix in the changelog
@@ -56,6 +56,7 @@ htmlcov/ | |||
coverage.xml | |||
*,cover | |||
.hypothesis/ | |||
.reports/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, nice!
@@ -166,6 +166,7 @@ New features: | |||
|
|||
Bug fixes: | |||
|
|||
* :bug:`4709` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a small description of the fix?
Reworked in another PR |
Description
Fixes #4709.
Changelog to complete if testing works out
To Do
docs/changelog.rst
to the bottom of one of the lists near the top of the document.)