Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lrclib lyrics #5406

Open
wants to merge 6 commits into
base: lyrics-refactor-tests
Choose a base branch
from
Open

Fix lrclib lyrics #5406

wants to merge 6 commits into from
+236 −54

Commits on Oct 30, 2024

  1. Fix fetching lyrics from lrclib 

    Adjust the base URL to perform a '/search' instead of attempting to
'/get' specific lyrics where we're unlikely to find lyrics for the
specific combination of album, artist, track names and the duration (see
https://lrclib.net/docs).

Since we receive an array of matching lyrics candidates, rank them by
their duration similarity to the item's duration, and whether they
contain synced lyrics.
    @snejus
    snejus committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    babe2e9 View commit details
    Browse the repository at this point in the history

  2. LRCLib: Improve exception handling

    @snejus
    snejus committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3dd6e2d View commit details
    Browse the repository at this point in the history

  3. Update lyrics.sources configuration to prioritize lrclib

    @snejus
    snejus committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    15ee767 View commit details
    Browse the repository at this point in the history

  4. lyrics/LRCLib: handle instrumental lyrics

    @snejus
    snejus committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4866991 View commit details
    Browse the repository at this point in the history

  5. Try to GET LRCLib lyrics before searching

    @snejus
    snejus committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d87cdce View commit details
    Browse the repository at this point in the history

  6. Remove trailing spaces in synced lyrics lines without text

    @snejus
    snejus committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    16188fa View commit details
    Browse the repository at this point in the history