Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow removing items or sources from config #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cloud-rocket
Copy link

@sampsyo - are you open to merge something like this to allow removing sources and deleting config items.

(This branch is for a review and not for merging now as it does not contain enough testing).

Thanks

@cloud-rocket cloud-rocket force-pushed the add-support-for-removing-entries branch from 681920b to 66ac22e Compare May 14, 2021 21:45
@cloud-rocket
Copy link
Author

@sampsyo - do you think you can merge it?

Thank you!

@sampsyo
Copy link
Member

sampsyo commented Oct 26, 2021

Hi! Seems generally useful, but perhaps somewhat tricky to explain exactly what's going on. Removing entire sources seems like it could have somewhat unpredictable effects on the data model. Removing individual keys (i.e., the opposite of add) seems perhaps more intuitive, but it also seems like it might be sort of difficult to guarantee that add and remove are actually opposites—that is, that removing something that was previously added at a given point in the configuration tree leaves us back in the original place. Does that make any sense?

It might be useful to have a somewhat broader conversation about the use case you're running into here so we can refine the proposal a bit. Is there a specific case where this came up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants