Testing using Jest #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the function form of the module to implement a pattern, that loads the module in CommonJS, AMD and Browser Globals. Therefore it tackles #3. Sprint can now be loaded in any CommonJS-like environment, AMD-like environments and regularly in the browser. * Call the function wrapper with the global this * Make Sprint a local variable * Export Sprint for AMD and CommonJS * Set `this.$` and `this.Sprint` for browsers
The offset was calculated relative to the viewport. pageYOffset / pageXOffset must be added to correct the result and return the offset relative to the whole document, like jQuery does.
When the height method was called for document, the method just retuned undefined. It returned before any value was calculated. * Added an exception for document in if clause * All properties for document height / width * Max call to select biggest value * New removeNaN helper function to clean array for Math.max
Fix document height
Fix offset() method
Added package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.